Files
GarminHealthLab/backend/tests/test_scheduler.py
ericwyuan 526ece7d14 refactor(sync): 手动同步与自动同步彻底分开
「历史范围」原本放在设置页,却只对同步页的一个按钮起作用;而同步页最
显眼的主按钮「同步最新数据」写死 2 天,根本不看这个设置。选了「全部
历史」再点主按钮,表现就是应用无视你 —— 这正是反复出现的「只同步下来
两天」。

现在两条链路各管各的:

* 自动同步:只在设置页配置(开关 + 频率),窗口固定 SYNC_DAYS,不再
  读 history_days。措辞也改成「拉取最近几天」,不再暗示会补历史。
* 手动同步:范围就在同步页当场选,紧挨着用它的按钮,并标出每个范围的
  实际代价(自上次同步 / 7 天 / … / 全部历史约 730 天、20-40 分钟)。
  两个按钮合成一个「开始同步」,写死 2 天的那个删掉。

history_days 保留为「上次手动选的范围」,只有同步页读它;默认值改成
-1(自上次同步),对日常使用是正确的起点。

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-01 09:20:52 +08:00

230 lines
8.1 KiB
Python

"""
Unit tests for the auto-sync scheduler.
The interesting behaviour is the claim: gunicorn runs several workers, each of
which starts its own timer, so without coordination one hourly tick would fire
a sync per worker.
"""
import datetime
import pytest
from services import scheduler
@pytest.fixture(autouse=True)
def _clean(db):
db.execute("DELETE FROM job_locks")
def set_last_run(db, when):
db.execute(
"UPDATE job_locks SET last_run_at = ? WHERE name = ?",
[when.isoformat(timespec="seconds"), scheduler.JOB_NAME],
)
class TestClaim:
def test_first_caller_gets_the_job(self, db):
assert scheduler.claim() is True
def test_second_caller_is_turned_away_while_the_first_holds_it(self, db, monkeypatch):
monkeypatch.setattr(scheduler.os, "getpid", lambda: 111)
assert scheduler.claim() is True
# A different worker, same instant.
monkeypatch.setattr(scheduler.os, "getpid", lambda: 222)
assert scheduler.claim() is False, "two workers must not run the same tick"
def test_not_due_again_within_the_interval(self, db):
scheduler.claim()
scheduler.release()
assert scheduler.claim() is False
def test_due_again_after_the_interval(self, db):
scheduler.claim()
scheduler.release()
set_last_run(db, datetime.datetime.utcnow() - datetime.timedelta(seconds=7200))
assert scheduler.claim() is True
def test_abandoned_claim_expires(self, db, monkeypatch):
"""A worker that dies mid-run must not block the job forever."""
monkeypatch.setattr(scheduler.os, "getpid", lambda: 111)
scheduler.claim()
stale = datetime.datetime.utcnow() - datetime.timedelta(
seconds=scheduler.CLAIM_TIMEOUT_SECONDS + 60
)
db.execute(
"UPDATE job_locks SET claimed_at = ? WHERE name = ?",
[stale.isoformat(timespec="seconds"), scheduler.JOB_NAME],
)
monkeypatch.setattr(scheduler.os, "getpid", lambda: 222)
assert scheduler.claim() is True
def test_release_without_running_leaves_it_due(self, db):
scheduler.claim()
scheduler.release(ran=False)
assert scheduler.claim() is True
def test_release_after_running_records_the_time(self, db):
scheduler.claim()
scheduler.release()
assert scheduler.status()["lastRunAt"] is not None
class TestSyncAllAccounts:
def test_no_accounts_is_a_no_op(self, db, user):
assert scheduler.sync_all_accounts() == []
def test_syncs_every_account_holding_a_token(self, db, user, monkeypatch, make_user):
from services import garmin as garmin_svc
other = make_user("b@example.com")
garmin_svc.save_token(user["id"], "t1", "a@example.com")
garmin_svc.save_token(other["id"], "t2", "b@example.com")
seen = []
monkeypatch.setattr(
garmin_svc, "sync_data",
lambda uid, creds, days=None, client=None: seen.append(uid)
or {"status": "success", "recordsSynced": days},
)
results = scheduler.sync_all_accounts(days=2)
assert set(seen) == {user["id"], other["id"]}
assert all(r["status"] == "success" for r in results)
def test_one_failing_account_does_not_stop_the_others(
self, db, user, monkeypatch, make_user
):
from services import garmin as garmin_svc
other = make_user("c@example.com")
garmin_svc.save_token(user["id"], "t1")
garmin_svc.save_token(other["id"], "t2")
def flaky(uid, creds, days=None, client=None):
if uid == user["id"]:
raise RuntimeError("token expired")
return {"status": "success", "recordsSynced": 2}
monkeypatch.setattr(garmin_svc, "sync_data", flaky)
results = scheduler.sync_all_accounts()
assert len(results) == 2
assert {r["status"] for r in results} == {"error", "success"}
def test_accounts_without_a_token_are_skipped(self, db, user, monkeypatch):
from services import garmin as garmin_svc
called = []
monkeypatch.setattr(
garmin_svc, "sync_data",
lambda *a, **k: called.append(1) or {"status": "success"},
)
scheduler.sync_all_accounts()
assert called == [], "an account with no token cannot be synced"
class TestStatus:
def test_reports_configuration(self, db):
s = scheduler.status()
assert s["intervalSeconds"] == scheduler.INTERVAL_SECONDS
assert s["days"] == scheduler.SYNC_DAYS
def test_next_run_follows_the_last(self, db):
scheduler.claim()
scheduler.release()
s = scheduler.status()
assert s["lastRunAt"] and s["nextRunAt"]
assert s["nextRunAt"] > s["lastRunAt"]
def test_no_run_yet(self, db):
s = scheduler.status()
assert s["lastRunAt"] is None
assert s["nextRunAt"] is None
class TestEndpoints:
def test_sync_latest_requires_auth(self, client):
assert client.post("/api/garmin/sync-latest", json={}).status_code == 401
def test_sync_latest_needs_a_bound_account(self, client, auth):
r = client.post("/api/garmin/sync-latest", headers=auth, json={})
assert r.status_code == 400
assert "绑定" in r.get_json()["error"]
def test_sync_latest_runs_inline(self, client, auth, user, db, monkeypatch):
from services import garmin as garmin_svc
garmin_svc.save_token(user["id"], "blob")
monkeypatch.setattr(
garmin_svc, "sync_data",
lambda uid, creds, days=None, client=None: {
"status": "success", "recordsSynced": days, "message": "ok",
},
)
r = client.post("/api/garmin/sync-latest", headers=auth, json={"days": 3})
assert r.status_code == 200
assert r.get_json()["recordsSynced"] == 3
def test_sync_latest_window_is_clamped(self, client, auth, user, db, monkeypatch):
from services import garmin as garmin_svc
garmin_svc.save_token(user["id"], "blob")
monkeypatch.setattr(
garmin_svc, "sync_data",
lambda uid, creds, days=None, client=None: {
"status": "success", "recordsSynced": days,
},
)
r = client.post("/api/garmin/sync-latest", headers=auth, json={"days": 999})
assert r.get_json()["recordsSynced"] == 7
def test_auto_sync_status_endpoint(self, client, auth):
r = client.get("/api/garmin/auto-sync", headers=auth)
assert r.status_code == 200
assert "intervalSeconds" in r.get_json()
class TestSyncWindowResolution:
"""Auto-sync must be blind to the manual sync range.
They used to share `history_days`: one setting on the 设置 page that only
took effect on the 数据同步 page, and that a half-hourly tick also used to
re-pull 730 days with. Separating them is the point.
"""
def _account(self, user, monkeypatch):
from services import garmin as garmin_svc
garmin_svc.save_token(user["id"], "t1")
seen = {}
def record(uid, creds, days=None, client=None):
seen["days"] = days
return {"status": "success", "recordsSynced": 0}
monkeypatch.setattr(garmin_svc, "sync_data", record)
return seen
def test_the_default_window_is_used(self, db, user, monkeypatch):
seen = self._account(user, monkeypatch)
results = scheduler.sync_all_accounts()
assert [r["status"] for r in results] == ["success"]
assert seen["days"] == scheduler.SYNC_DAYS
def test_the_manual_range_is_ignored(self, db, user, monkeypatch):
"""全部历史 on the sync page must not turn every tick into 730 days."""
from services import settings as settings_svc
seen = self._account(user, monkeypatch)
settings_svc.save_settings(user["id"], {"historyDays": 0})
scheduler.sync_all_accounts(respect_schedule=True)
assert seen["days"] == scheduler.SYNC_DAYS
def test_an_explicit_override_still_wins(self, db, user, monkeypatch):
seen = self._account(user, monkeypatch)
scheduler.sync_all_accounts(days=30)
assert seen["days"] == 30